Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-algorand 3.8.0-stable Release PR #4189

Merged
merged 24 commits into from
Jul 2, 2022

Conversation

Algo-devops-service
Copy link
Contributor

@Algo-devops-service Algo-devops-service commented Jun 28, 2022

GitHub Logo

Overview

The goal command is now using the participation key REST API. A byproduct of this is that keys are no longer copied into the data directory, instead they are installed directly into the internal participation key registry.

What's New

  • Participation Key Interface cleanup
  • Adding support for m1 builds to pipeline
  • Other miscellaneous bug fixes and enhancements

Changelog

New Features

  • CICD: Add m1 to build pipeline (#4079)

Enhancements

  • AVM: Make it easier to move experimental opcode groups (#4123)
  • AVM: Track Scratch Slot Types (#4064)
  • CICD: update build pipeline for darwin-amd64 (#4147)
  • CICD: Optimizing CircleCI cache usage (#4087)
  • Devops: Define recipe for FastNet. (#4066)
  • Ledger: fix typo in error.go (#4143)
  • Metrics: specify telemetry hostname and instance name as prometheus labels (#4089)
  • Misc: Add helper functions to genesis. (#4111)
  • Pingpong: improve transaction scheduling (#3478)
  • PKI: Enable full usage of REST API to install participation keys (#4002)

Bugfixes

  • AVM: Version downgrade check ported to master (#4093) (in v3.7.2)
  • Bug Fix: Adds validity round check for failing tests (#4085)
  • Catchpointdump: fixes (#4130)
  • Ledger: fix flakiness in TestReproducibleCatchpointLabels (#4074)
  • Network: message-of-interest tiny bugfix (#4107) (in v3.7.2)
  • Tools: Fixing calls to pingpong with deprecated flag --REST (#4070)

Other

Protocol Upgrade

This release does not contain a protocol upgrade.


NOTE
vFuture changes are not yet available in MainNet or TestNet but can be used in private networks.

New Features

  • AVM: replace opcodes (#4129)

Enhancements

  • AVM: Set proper costs for json_ref (#4096)

Additional Resources

tolikzinovyev and others added 24 commits June 1, 2022 19:20
…orand#4002)

* Migrate goal account commands to REST API (algorand#3916)
* PKI: 3924 handle stateproof in rest api goal (algorand#3950)

Some additional refactoring:
* Remove Node Key Monitoring Function
* Removes function which calls loadParticipationKeys() every 60 seconds
  since MakeFull() for the FullNode does the same thing

Co-authored-by: Will Winder <wwinder.unh@gmail.com>
* Allow app downgrades in old protocol versions

* Tweak comments to reflect MinInnerApplVersion better.

* Update ledger/internal/apptxn_test.go

Co-authored-by: John Jannotti <jannotti@gmail.com>

* Update data/transactions/transaction.go

Co-authored-by: John Jannotti <jannotti@gmail.com>

* Update ledger/internal/apptxn_test.go

Co-authored-by: John Jannotti <jannotti@gmail.com>

* Update ledger/internal/apptxn_test.go

Co-authored-by: John Jannotti <jannotti@gmail.com>

Co-authored-by: John Jannotti <jannotti@gmail.com>
Use Algorand’s JSON codec to improve performance

Add stack depth parameter to linear cost model

Use stack label for linear cost depth doc

Co-authored-by: Jacob Daitzman <jdtzmn@gmail.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

Co-authored-by: michaeldiamant <michaeldiamant@users.noreply.github.com>
…abels (algorand#4089)

* specify telemetry hostname in prometheus metrics, if available

* also get telemetry InstanceName tag

* rename GetTelemetryHostName to GetTelemetryHostID

* rename telemetry HostName to TelemetryGUID
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
backport replace opcodes from box work
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #4189 (641a1f1) into rel/stable (ccb2ec3) will increase coverage by 0.12%.
The diff coverage is 34.05%.

@@              Coverage Diff               @@
##           rel/stable    #4189      +/-   ##
==============================================
+ Coverage       54.46%   54.59%   +0.12%     
==============================================
  Files             391      391              
  Lines           48665    48732      +67     
==============================================
+ Hits            26506    26605      +99     
+ Misses          19933    19908      -25     
+ Partials         2226     2219       -7     
Impacted Files Coverage Δ
cmd/goal/account.go 12.48% <0.00%> (-0.47%) ⬇️
config/version.go 9.09% <ø> (ø)
daemon/algod/server.go 4.87% <0.00%> (-0.13%) ⬇️
data/transactions/transaction.go 35.80% <ø> (ø)
ledger/ledgercore/error.go 0.00% <ø> (ø)
libgoal/libgoal.go 2.74% <0.00%> (-0.05%) ⬇️
libgoal/participation.go 0.00% <0.00%> (ø)
libgoal/transactions.go 0.00% <0.00%> (ø)
logging/log.go 41.26% <0.00%> (ø)
logging/telemetryConfig.go 81.81% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb2ec3...641a1f1. Read the comment docs.

@algojack
Copy link
Contributor

Seems CodeCov is calling out some code for not being covered in tests.
As well as Lint complaining about some missing things. Only shown on the Files tab.

Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algojohnlee algojohnlee merged commit d867a09 into algorand:rel/stable Jul 2, 2022
@onetechnical onetechnical deleted the relstable3.8.0 branch July 2, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet