Tests: Convert goal app info expect test to e2e #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
changed the title
jasonpaulos
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4449 +/- ##
==========================================
+ Coverage 55.19% 55.23% +0.03%
==========================================
Files 398 398
Lines 50165 50165
==========================================
+ Hits 27689 27708 +19
+ Misses 20159 20147 -12
+ Partials 2317 2310 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
michaeldiamant
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
@jasonpaulos Thanks for the effort here - the new test mirrors the old test's form + adds assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the existing
statefulTealAppInfoTest.expexpect test to a newgoal-app-info.she2e test.The original test was flaky, so this should hopefully reduce test flakiness.
Note the new test is not exactly the same, as it simplifies the test setup and tests new outputs that did not exist when the original test was written. However, these changes should increase the strength of this test.
Test Plan
Test migrated.