Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netgoal: start with at least 20GB RootStorage #4779

Merged

Conversation

algolucky
Copy link
Contributor

@algolucky algolucky commented Nov 9, 2022

Summary

  • bumps the constant when calculating required storage for instances using netgoal to 20
    • for instance, with a single NPN and no relays, the return value changes from 20 to 30
    • this was highlighted when spinning up mainnet NPNs and running fast-catchup, the data directories are approaching, if not exceeding, 20GB

Test Plan

  • load generator pipeline

@algolucky algolucky self-assigned this Nov 9, 2022
@algolucky algolucky changed the title netgoal: start with 20GB RootStorage netgoal: start with at least 20GB RootStorage Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #4779 (7e8aaca) into master (995ae47) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4779      +/-   ##
==========================================
+ Coverage   54.59%   54.61%   +0.01%     
==========================================
  Files         414      414              
  Lines       53517    53517              
==========================================
+ Hits        29219    29226       +7     
+ Misses      21878    21868      -10     
- Partials     2420     2423       +3     
Impacted Files Coverage Δ
netdeploy/remote/deployedNetwork.go 19.77% <0.00%> (ø)
data/transactions/verify/txn.go 76.19% <0.00%> (-0.96%) ⬇️
ledger/testing/randomAccounts.go 56.61% <0.00%> (-0.62%) ⬇️
ledger/acctonline.go 78.12% <0.00%> (-0.53%) ⬇️
catchup/service.go 68.14% <0.00%> (-0.50%) ⬇️
ledger/accountdb.go 72.55% <0.00%> (-0.16%) ⬇️
ledger/tracker.go 74.89% <0.00%> (ø)
network/wsNetwork.go 65.80% <0.00%> (+0.46%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algolucky algolucky marked this pull request as ready for review November 10, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants