Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix resolver test endpoint #4784

Merged
merged 1 commit into from Nov 14, 2022

Conversation

Eric-Warehime
Copy link
Contributor

Summary

resolver_test.go is failing because gmail's jabber SRV records seem not to exist anymore. I've updated the test to point to our own telemetry SRV records for devnet.

Test Plan

Unit test passes.

@Eric-Warehime Eric-Warehime changed the title Fix resolver test endpoint tests: Fix resolver test endpoint Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #4784 (6c1138b) into master (1a13168) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4784      +/-   ##
==========================================
- Coverage   54.71%   54.69%   -0.03%     
==========================================
  Files         414      414              
  Lines       53548    53548              
==========================================
- Hits        29299    29287      -12     
- Misses      21825    21834       +9     
- Partials     2424     2427       +3     
Impacted Files Coverage Δ
ledger/tracker.go 74.04% <0.00%> (-4.69%) ⬇️
ledger/testing/randomAccounts.go 56.00% <0.00%> (-1.24%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/acctonline.go 78.12% <0.00%> (-0.53%) ⬇️
ledger/accountdb.go 72.55% <0.00%> (-0.08%) ⬇️
network/wsNetwork.go 65.80% <0.00%> (ø)
ledger/acctupdates.go 69.51% <0.00%> (+0.24%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️
network/netprio.go 78.26% <0.00%> (+8.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but it does mean our tests are dependent on DevNet's DNS records. That's not the worst thing, but is a point of failure (and we do reserve the right to "reset" DevNet, during which time this will fail these checks.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants