Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goal: user defined scheme to connect to remote host #4922

Merged
merged 1 commit into from Mar 11, 2023

Conversation

win-t
Copy link
Contributor

@win-t win-t commented Dec 19, 2022

Related to #2904

I use this patch to connect to a remote node

for example, connecting to https://algonode.io/api/

$ echo https://mainnet-api.algonode.cloud > algod.net
$ echo 0000000000000000000000000000000000000000000000000000000000000000 > algod.token
$ goal -d $PWD account info -a ZW3ISEHZUHPO7OZGMKLKIIMKVICOUDRCERI454I3DB2BH52HGLSO67W754
Created Assets:
	ID 473073010, PW:GOV1, supply 3198752 PW_GOV1, https://bit.ly/3FouyUR
	ID 815226506, PW:GOV2, supply 10855648 PW_GOV2, https://www.planetwatch.io/governance-vote-type-2-rewards/
	ID 850324927, PW:GOV3, supply 10101621 PW_GOV3, https://www.planetwatch.io/governance-vote-recycle-bins-data-streams-recording
	ID 864913853, PW:GOV4, supply 9865201 PW_GOV4, https://www.planetwatch.io/governance-vote-extending-voting-rights-to-planet-holders/
	ID 963327370, PW:GOV5, supply 11000000 PW_GOV5, https://www.planetwatch.io/governance-vote-token-model-update/
Held Assets:
	ID 27165954, PLANET, balance 64959512.528857 Planets
	ID 395684495, PLANET Recycled Token, balance 3377426128.001016 PW_BIN
	ID 473073010, PW:GOV1, balance 2451323 PW_GOV1
	ID 815226506, PW:GOV2, balance 9658818 PW_GOV2
	ID 850324927, PW:GOV3, balance 9405236 PW_GOV3
	ID 864913853, PW:GOV4, balance 8851732 PW_GOV4
	ID 963327370, PW:GOV5, balance 9756771 PW_GOV5
Created Apps:
	<none>
Opted In Apps:
	<none>
Minimum Balance:	800000 microAlgos

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2022

CLA assistant check
All committers have signed the CLA.

@win-t win-t mentioned this pull request Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #4922 (a1dabec) into master (e6c3463) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4922      +/-   ##
==========================================
+ Coverage   53.52%   53.54%   +0.01%     
==========================================
  Files         431      431              
  Lines       53533    53538       +5     
==========================================
+ Hits        28656    28666      +10     
+ Misses      22654    22650       -4     
+ Partials     2223     2222       -1     
Impacted Files Coverage Δ
nodecontrol/algodControl.go 3.90% <0.00%> (-0.10%) ⬇️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
data/transactions/verify/txn.go 73.72% <0.00%> (-0.85%) ⬇️
ledger/tracker.go 75.10% <0.00%> (-0.85%) ⬇️
ledger/acctonline.go 78.44% <0.00%> (-0.52%) ⬇️
network/wsNetwork.go 64.92% <0.00%> (+0.17%) ⬆️
catchup/service.go 70.53% <0.00%> (+1.20%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy
Copy link
Contributor

@winder @cce opinions?

@win-t win-t changed the title use https if connect to remote host user defined shceme to connect to remote host Dec 20, 2022
@bbroder-algo
Copy link
Contributor

This patch appears to enable https access to a node, whereas before it was only http. This seems like a good thing. Any opinions?

@barnjamin
Copy link
Contributor

This patch appears to enable https access to a node, whereas before it was only http. This seems like a good thing. Any opinions?

necessary for pointing it at public APIs, I cant think of a downside?

@algorandskiy algorandskiy changed the title user defined shceme to connect to remote host algod: user defined shceme to connect to remote hosta Mar 6, 2023
@algorandskiy algorandskiy changed the title algod: user defined shceme to connect to remote hosta algod: user defined scheme to connect to remote hosta Mar 6, 2023
@algorandskiy algorandskiy changed the title algod: user defined scheme to connect to remote hosta algod: user defined scheme to connect to remote host Mar 6, 2023
@winder winder changed the title algod: user defined scheme to connect to remote host goal: user defined scheme to connect to remote host Mar 11, 2023
@winder winder merged commit 7b11fc7 into algorand:master Mar 11, 2023
@win-t win-t deleted the https-if-remote branch March 12, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants