-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Fix t.Parallel() errors in cmd package #4991
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4991 +/- ##
==========================================
- Coverage 53.44% 53.42% -0.02%
==========================================
Files 431 431
Lines 54364 54364
==========================================
- Hits 29056 29046 -10
- Misses 23053 23064 +11
+ Partials 2255 2254 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! I confirmed locally that the tests pass with the given test command. I found that some of the test files were not caught currently by golangci (see #5046 for more information) and added a commit to address those errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased master into this branch, and checked linter and for flakiness by running the race flag. Also added a commit (0368212) to disable linting on the newest set of cmd tests, which seem to share os variables.
Enables https://github.com/kunwardeep/paralleltest on
cmd
by fixing linter warnings. Incrementally moves the ball towards greater unit test parallelization, which reduces local + CI test durations.I vetted for flakiness by running:
Notes: