Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateproof: avoid removing registry record if state proof keys exist #5065

Draft
wants to merge 3 commits into
base: feature/stateproofs-recoverability
Choose a base branch
from

Conversation

algonathan
Copy link
Contributor

Summary

Test Plan

@algonathan algonathan requested a review from id-ms January 26, 2023 15:56
@algonathan algonathan self-assigned this Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #5065 (e88d419) into feature/stateproofs-recoverability (cd7c667) will increase coverage by 0.02%.
The diff coverage is 64.10%.

@@                          Coverage Diff                           @@
##           feature/stateproofs-recoverability    #5065      +/-   ##
======================================================================
+ Coverage                               53.90%   53.92%   +0.02%     
======================================================================
  Files                                     434      434              
  Lines                                   54617    54649      +32     
======================================================================
+ Hits                                    29441    29470      +29     
+ Misses                                  22884    22873      -11     
- Partials                                 2292     2306      +14     
Impacted Files Coverage Δ
data/account/registeryDbOps.go 72.18% <63.63%> (-1.67%) ⬇️
data/account/participationRegistry.go 77.64% <64.70%> (-0.86%) ⬇️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
catchup/service.go 68.59% <0.00%> (-2.66%) ⬇️
ledger/testing/randomAccounts.go 55.65% <0.00%> (-1.23%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-0.45%) ⬇️
ledger/acctupdates.go 68.91% <0.00%> (-0.25%) ⬇️
ledger/blockqueue.go 88.50% <0.00%> (+2.87%) ⬆️
data/accountManager.go 53.57% <0.00%> (+36.90%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant