Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algod: Leverage 2 SRV record providers for resolving relay addresses w/ de-duplication. #5087

Merged
merged 28 commits into from
Jun 7, 2023
Merged

Algod: Leverage 2 SRV record providers for resolving relay addresses w/ de-duplication. #5087

merged 28 commits into from
Jun 7, 2023

Commits on Jun 7, 2023

  1. Initial cut of relay resolution/dedup from primary/secondary providers.

    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    7b59509 View commit details
    Browse the repository at this point in the history

  2. Introduce Rapid library for property based tests. Initial cut of doma… 

    …in generators for use with Rapid testing library.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ea7fa74 View commit details
    Browse the repository at this point in the history

  3. Basic functioning property based test example for updatePhonebookAddr… 

    …esses
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    76e8f21 View commit details
    Browse the repository at this point in the history

  4. Full implementation of rapid tests for updatePhonebookRecords.

    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    4ad55b3 View commit details
    Browse the repository at this point in the history

  5. Address linter complaints related to daomin gen files.

    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    cb6551d View commit details
    Browse the repository at this point in the history

  6. Testing exercising merging of primary/secondary relay addresses - cov… 

    …ers cases with minimal and various definition of 'partial' overlaps.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    8e71a51 View commit details
    Browse the repository at this point in the history

  7. Put rapidgenerators in internal package.

    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ece1fde View commit details
    Browse the repository at this point in the history

  8. feedback from initial CR

    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    63733cf View commit details
    Browse the repository at this point in the history

  9. Introduce dnsBootstrap config struct along with expression parser to … 

    …enable flexible templates for dns resolution. Includes explicitly configuring a backup bootstrap along with an expression to be used for filtering duplicate hosts resolved between providers.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    786762f View commit details
    Browse the repository at this point in the history

  10. Resolve flaky test based on duplicate addresses showing up as both re… 

    …lay and archive nodes.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9e9cb2f View commit details
    Browse the repository at this point in the history

  11. Add varying test scenarios for relay address overlaps with different … 

    …dedup expressions in wsNetwork_test. Remove $ from being appended to end of DNSBootstrap expression.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    61c4a90 View commit details
    Browse the repository at this point in the history

  12. Remove completely false comment.

    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    40e3d66 View commit details
    Browse the repository at this point in the history

  13. Make outstanding call to replace peer list use networkID as in our ot… 

    …her calls.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ed1a901 View commit details
    Browse the repository at this point in the history

  14. Bug fix; slices in UpdatePhoneBookAddresses should be initialized wit… 

    …h length 0.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    bc0d342 View commit details
    Browse the repository at this point in the history

  15. Set updated template to reflect algorand.network as primary, algorand… 

    ….net as backup, with dedup pattern between resolved addresses from the two.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    5610f1b View commit details
    Browse the repository at this point in the history

  16. Incorporate input from code review: error naming, code simplications,… 

    … in-depth description of how ParseDNSBootstrap behaves.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    661a3da View commit details
    Browse the repository at this point in the history

  17. Update nodeDir's interactions with config to access DNSBootstrapID vi… 

    …a the appropriate builder function.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    d7a929d View commit details
    Browse the repository at this point in the history

  18. Add missing partitiontest to TestUpdatePhonebookAddresses in network/… 

    …wsNetwork_test.go

Co-authored-by: Will Winder <wwinder.unh@gmail.com>
    @gmalouf @winder
    gmalouf and winder committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    b7fca09 View commit details
    Browse the repository at this point in the history

  19. Update import ordering in config/dnsbootstrap.go 

    Co-authored-by: Will Winder <wwinder.unh@gmail.com>
    @gmalouf @winder
    gmalouf and winder committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a6a5d0e View commit details
    Browse the repository at this point in the history

  20. REmove redundant godoc line in config/dnsbootstrap.go 

    Co-authored-by: Will Winder <wwinder.unh@gmail.com>
    @gmalouf @winder
    gmalouf and winder committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    c9f15d5 View commit details
    Browse the repository at this point in the history

  21. Tidying cleanup.

    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    8b00cc4 View commit details
    Browse the repository at this point in the history

  22. Fix bug preventing linter from running and address linting issues tha… 

    …t had been hidden as a result.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    377beff View commit details
    Browse the repository at this point in the history

  23. Update cmd/catchupsrv/download.go 

    Co-authored-by: cce <51567+cce@users.noreply.github.com>
    @gmalouf @cce
    gmalouf and cce committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    c0a942c View commit details
    Browse the repository at this point in the history

  24. Introduce unit/functional test for refreshRelayArchivePhonebookAddres… 

    …ses.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    421f454 View commit details
    Browse the repository at this point in the history

  25. Compilation fix post-rename.

    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a094101 View commit details
    Browse the repository at this point in the history

  26. Remove panic from DNSBootstrapArray call, splitting the function into… 

    … validate and just parse flavors. The Validate function is now called during bootstrapping in both the algod and algoh main functions (where errors stop start up).
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    af44394 View commit details
    Browse the repository at this point in the history

  27. Patch DNSBootstrap setting logic in netdeploy.

    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    87b51ef View commit details
    Browse the repository at this point in the history

  28. Remove stopOnError flag from internvalValidateDNSBootstrapID in local… 

    …Template. In practice, there is no reason to vary whether or not we stop in validate vs 'just read' modes.
    @gmalouf
    gmalouf committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    06a432d View commit details
    Browse the repository at this point in the history