ledger: fix error shadowing in onlineAccountsNewRoundImpl #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5188 +/- ##
==========================================
+ Coverage 53.52% 53.53% +0.01%
==========================================
Files 439 439
Lines 54985 54993 +8
==========================================
+ Hits 29429 29443 +14
+ Misses 23270 23262 -8
- Partials 2286 2288 +2
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
changed the title
jannotti
previously approved these changes
Mar 10, 2023
Co-authored-by: John Jannotti <jannotti@gmail.com>
jannotti
approved these changes
Mar 10, 2023
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
errshadowing introduced in #5177Also add a small refactoring around Ledger and SigLedger initialization
Test Plan
Added new test