Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix esingle-payer-swap e2e subs test #5189

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Mar 10, 2023

Summary

Prevent test failure when base64 encoded fields have "fee" substring.

code:

FOUND=$(msgpacktool -d < cheap.txn | grep fee)
set -e
if [[ $FOUND != "" ]]; then
    date "+{scriptname} FAIL fee was improperly encoded $FOUND %Y%m%d_%H%M%S"
    false
fi

Output

{scriptname} FAIL fee was improperly encoded     "rcv:b64": "0X97nHcwgnkkYfeeY5XGNP6gVUpfbRUJMPNi8tMp4t8=", 20230310_160027

Test Plan

This is a test fix

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #5189 (ad42f2a) into master (485ad92) will decrease coverage by 11.35%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5189       +/-   ##
===========================================
- Coverage   53.49%   42.15%   -11.35%     
===========================================
  Files         439      439               
  Lines       55004    55004               
===========================================
- Hits        29426    23187     -6239     
- Misses      23288    29485     +6197     
- Partials     2290     2332       +42     

see 219 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jannotti jannotti merged commit 7954f8e into algorand:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants