Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: set reviewdog golangci-lint go version #5196

Merged
merged 3 commits into from Mar 11, 2023

Conversation

cce
Copy link
Contributor

@cce cce commented Mar 10, 2023

Summary

The reviewdog runs for golangci-lint have recently been crashing with the error panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt and it seems pinning the Go version fixes it.

This also fixes two lint errors that snuck through recently.

Test Plan

Reviewdog golangci-lint should run without crashing

@cce cce marked this pull request as ready for review March 10, 2023 20:41
@cce cce requested a review from winder March 10, 2023 20:57
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #5196 (9591201) into master (ae33119) will decrease coverage by 1.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5196      +/-   ##
==========================================
- Coverage   53.55%   51.91%   -1.65%     
==========================================
  Files         439      439              
  Lines       55012    55012              
==========================================
- Hits        29463    28560     -903     
- Misses      23270    24122     +852     
- Partials     2279     2330      +51     
Impacted Files Coverage Δ
logging/telemetryspec/metric.go 81.91% <ø> (ø)
ledger/internal/appcow.go 67.32% <100.00%> (-7.61%) ⬇️

... and 88 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but this wouldn't fetch the minor version. Is that important?

The Indexer version of this file seems to have diverged quite a bit. It uses a separate step in the job to install go

@cce cce requested a review from bbroder-algo March 10, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants