Fix: Tech Debt (wsNetwork "auto" and OnlineAccountsDelete comment) #5207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlgoAxel
commented
Mar 15, 2023
AlgoAxel
commented
- Rename "auto" to "testing" in wsNetwork for clarity
- Rewrite OnlineAccountsDelete comment for correctness
* Rename "auto" to "testing" in wsNetwork for clarity * Rewrite OnlineAccountsDelete comment for correctness
Codecov Report
@@ Coverage Diff @@
## master #5207 +/- ##
==========================================
- Coverage 53.51% 52.58% -0.94%
==========================================
Files 439 439
Lines 55012 55012
==========================================
- Hits 29442 28928 -514
- Misses 23283 23759 +476
- Partials 2287 2325 +38
... and 59 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Mar 15, 2023
bbroder-algo
approved these changes
Mar 17, 2023
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Mar 23, 2023
This was referenced May 9, 2023
| @@ -651,7 +651,12 @@ func (w *accountsV2Writer) TxtailNewRound(ctx context.Context, baseRound basics. | |||
| return err | |||
| } | |||
|
|
|||
| // OnlineAccountsDelete deleted entries with updRound <= expRound | |||
| // OnlineAccountsDelete cleans up the Online Accounts table to prune expired entires. | |||
| // it will delete entries with an updRound <= expRound | |||
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.