Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: option to override topology file and peer address. #5209

Merged
merged 10 commits into from Mar 29, 2023

Conversation

shiqizng
Copy link
Contributor

@shiqizng shiqizng commented Mar 15, 2023

updating dockerfile to support devmode + followermode container

  • supporting private network topology override.
  • adding a new env var PEER_ADDRESS for running multiple containers. A follower node container can connect to the relay node container by setting the host:port inPEER_ADDRESS .

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #5209 (f8d8afa) into master (c556cfc) will decrease coverage by 8.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5209      +/-   ##
==========================================
- Coverage   53.57%   44.66%   -8.91%     
==========================================
  Files         441      441              
  Lines       55094    55094              
==========================================
- Hits        29515    24608    -4907     
- Misses      23300    28148    +4848     
- Partials     2279     2338      +59     

see 196 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shiqizng shiqizng self-assigned this Mar 15, 2023
@shiqizng shiqizng changed the title dockerfile update docker container: dockerfile update Mar 15, 2023
@shiqizng shiqizng marked this pull request as ready for review March 15, 2023 21:19
docker/files/run/run.sh Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
@shiqizng shiqizng requested a review from winder March 16, 2023 15:23
docker/README.md Outdated Show resolved Hide resolved
winder
winder previously approved these changes Mar 16, 2023
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docker/README.md Outdated Show resolved Hide resolved
excalq
excalq previously approved these changes Mar 28, 2023
@shiqizng shiqizng dismissed stale reviews from excalq and winder via aa67135 March 28, 2023 17:41
@shiqizng shiqizng requested review from winder and excalq March 28, 2023 17:44
@winder winder merged commit 7738691 into algorand:master Mar 29, 2023
9 checks passed
@winder winder changed the title docker container: dockerfile update docker: option to override topology file and peer address. Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants