Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal: Introduce new command for simulate #5213

Merged
merged 12 commits into from Mar 21, 2023

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Mar 17, 2023

Summary

Introduce goal clerk simulate for simulation feature.

Test Plan

e2e-sub test

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #5213 (478d816) into master (ca04d83) will increase coverage by 0.00%.
The diff coverage is 45.94%.

@@           Coverage Diff           @@
##           master    #5213   +/-   ##
=======================================
  Coverage   53.56%   53.57%           
=======================================
  Files         441      441           
  Lines       55098    55122   +24     
=======================================
+ Hits        29515    29532   +17     
- Misses      23298    23309   +11     
+ Partials     2285     2281    -4     
Impacted Files Coverage Δ
cmd/goal/application.go 17.78% <ø> (ø)
libgoal/libgoal.go 2.51% <0.00%> (-0.03%) ⬇️
cmd/goal/clerk.go 9.10% <53.12%> (+0.32%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbroder-algo
Copy link
Contributor

seems like the right way forward

@ahangsu ahangsu marked this pull request as ready for review March 18, 2023 00:58
libgoal/libgoal.go Outdated Show resolved Hide resolved
barnjamin
barnjamin previously approved these changes Mar 20, 2023
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Minor testing comment: might be interesting to also test something with a failure message (e.g. overspend).

test/scripts/e2e_subs/e2e-app-simulate.sh Outdated Show resolved Hide resolved
cmd/goal/clerk.go Show resolved Hide resolved
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, and nice tests

cmd/goal/clerk.go Outdated Show resolved Hide resolved
cmd/goal/clerk.go Show resolved Hide resolved
daemon/algod/api/client/restClient.go Outdated Show resolved Hide resolved
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants