Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Change dd argument to use a bytes value #5263

Merged
merged 2 commits into from Apr 6, 2023

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Apr 6, 2023

Summary

Changes dd's bs argument to a bytes value to work on both macOS (specifically, CircleCI's macOS 11) and linux. Also added a comment above the line to justify this:

# Some of our MacOS nightly tests fail for specifying the bs (block size)
# value in capital letters (i.e. 11M), so just specify it as 1024 bytes and
# allocate 11K blocks so we get a 11MB sized file. 

Nightly integration tests seem to pass now: https://app.circleci.com/pipelines/github/algorand/go-algorand/13522/workflows/2cca47be-d835-48c3-897e-7f713e521534

@algochoi algochoi changed the title tests: Change dd argument from uppercase to lowercase tests: Change dd argument to use a bytes value Apr 6, 2023
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin good

@algochoi algochoi marked this pull request as ready for review April 6, 2023 18:47
@algochoi algochoi requested a review from winder April 6, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants