ledger: fix error shadowing in accountsNewRound #5266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rewrote accountsNewRound and onlineAccountsNewRound to return immediately * This has a behavior change: all the updated* return values are now empty on error
algonautshant
approved these changes
Apr 6, 2023
icorderi
approved these changes
Apr 18, 2023
cce
reviewed
Apr 18, 2023
|
|
||
| if err != nil { | ||
| return | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think a function of this length should use naked returns at all
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed err shadowing in accountsNewRound and rewrote accountsNewRound and onlineAccountsNewRound to return immediately. This is a slight behavior change: all the updated* return values are now empty on error
Test Plan
Added new test. Existing tests passed.