Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: enforce maximum header size on outgoing ws conns #5268

Merged
merged 8 commits into from Apr 18, 2023
Merged

network: enforce maximum header size on outgoing ws conns #5268

merged 8 commits into from Apr 18, 2023

Conversation

iansuvak
Copy link
Contributor

@iansuvak iansuvak commented Apr 6, 2023 •
edited

Summary

Enforce explicit max header size in the initial upgrader HTTP response when making an outgoing websocket connection

Test Plan

  • Should pass existing tests
  • Add a new test that ensures that the limits are being enforced correctly

@algorandskiy algorandskiy changed the title enhance: enforce maximum header size on outgoing ws conns network: enforce maximum header size on outgoing ws conns Apr 6, 2023
algorandskiy
algorandskiy reviewed Apr 6, 2023
View reviewed changes
go.mod Show resolved Hide resolved
network/wsNetwork_test.go Show resolved Hide resolved
algonautshant
algonautshant reviewed Apr 13, 2023
View reviewed changes
network/wsNetwork.go Outdated Show resolved Hide resolved
iansuvak and others added 2 commits April 13, 2023 15:07
@iansuvak
Fix race in the test
b581552
@iansuvak @algonautshant
Update network/wsNetwork.go
23f4c77 
Co-authored-by: Shant Karakashian <55754073+algonautshant@users.noreply.github.com>
algorandskiy
algorandskiy previously approved these changes Apr 18, 2023
View reviewed changes
algonautshant
algonautshant previously approved these changes Apr 18, 2023
View reviewed changes
algonautshant
algonautshant approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the updates.

@algorandskiy algorandskiy merged commit 15bc838 into algorand:master Apr 18, 2023
22 checks passed
This was referenced May 9, 2023
Closed
Closed
Closed
@Algo-devops-service Algo-devops-service mentioned this pull request May 22, 2023
Merged
This was referenced May 24, 2023
Merged
Merged
Merged
@Algo-devops-service Algo-devops-service mentioned this pull request Jun 12, 2023
Merged
@onetechnical onetechnical mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algonautshant algonautshant algonautshant approved these changes

@algorandskiy algorandskiy algorandskiy approved these changes

@cce cce Awaiting requested review from cce

@AlgoAxel AlgoAxel Awaiting requested review from AlgoAxel

Assignees

@iansuvak iansuvak

Labels
Enhancement Team Carbon-11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iansuvak @algonautshant @algorandskiy