New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: search/replace indexer/conduit in block-generator #5321
Merged
winder
merged 16 commits into
algorand:master
from
tzaffi:tzaffi/block-generator-tweaks
Apr 28, 2023
Merged
tools: search/replace indexer/conduit in block-generator #5321
winder
merged 16 commits into
algorand:master
from
tzaffi:tzaffi/block-generator-tweaks
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
commented
Apr 20, 2023
tzaffi
commented
Apr 20, 2023
tzaffi
commented
Apr 20, 2023
shiqizng
reviewed
Apr 21, 2023
shiqizng
reviewed
Apr 21, 2023
RunnerCmd.Flags().StringVarP(&runnerArgs.LogLevel, "log-level", "l", "error", "LogLevel to use when starting Indexer. [panic, fatal, error, warn, info, debug, trace]") | ||
RunnerCmd.Flags().StringVarP(&runnerArgs.CPUProfilePath, "cpuprofile", "", "", "Path where Indexer writes its CPU profile.") | ||
RunnerCmd.Flags().StringVarP(&runnerArgs.LogLevel, "log-level", "l", "error", "LogLevel to use when starting Conduit. [panic, fatal, error, warn, info, debug, trace]") | ||
RunnerCmd.Flags().StringVarP(&runnerArgs.CPUProfilePath, "cpuprofile", "", "", "Path where Conduit writes its CPU profile.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making a note to myself that I need to add this to the config template.
shiqizng
previously approved these changes
Apr 21, 2023
shiqizng
approved these changes
Apr 21, 2023
algochoi
reviewed
Apr 21, 2023
algochoi
approved these changes
Apr 21, 2023
tzaffi
changed the title
tools: copy/replace indexer/conduit in block-generator
tools: search/replace indexer/conduit in block-generator
Apr 21, 2023
Eric-Warehime
approved these changes
Apr 24, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replacing mentions of "indexer" with "conduit" and some other small tweaks.
Test Plan
Locally tested by running
inside of
tools/block-generator
(after copying over aconduit
binary)