REST: add the round number to algod box endpoint repsonse

[bbroder-algo]

Summary

Include the round that the value of the box's contents is pulled from to the response from v2/box endpoint

Test Plan

Modified e2e to check rounds.

[jannotti]

Seems like a good idea and correct implementation to me.

[bbroder-algo]

I made up the round numbers in the e2e test, they need to be replaced with the right answer.

[jannotti]

I made up the round numbers in the e2e test, they need to be replaced with the right answer.

Will that even be possible? Are these e2e tests run deterministically? (the e2e_subs are not)

[bbroder-algo]

Ran in sandbox, caught up to testnet, found an app with a box, ran box endpoint:

bob@algobob sandbox #curl -i -H "X-Algo-API-Token:${AUTH_TOKEN}" "localhost:31200/v2/applications/200641557/box?name=b64:ABrYmUED76S3MLW1Lkb0mvlRD0YJD2rX2y5QIu%2FqXz09"
HTTP/1.1 200 OK
Content-Type: application/json; charset=UTF-8
Vary: Origin
Date: Thu, 27 Apr 2023 22:36:28 GMT
Content-Length: 120

{"name":"ABrYmUED76S3MLW1Lkb0mvlRD0YJD2rX2y5QIu/qXz09","round":29457190,"value":"AAAAAAAhQ6AAAAAAZD+e9AAAAAAABfXhAA=="}
bob@algobob sandbox #

[ahangsu]

seems right

[bbroder-algo]

@jasonpaulos would it be better to add the round in BoxResponse instead? BoxResponse uses a schema reference though, and I seem to remember something about not being able to add to a schema reference.

[jasonpaulos]

No, this makes sense here. The schema ref that BoxResponse uses means it's really just an alias to Box. See our generated type here:

go-algorand/daemon/algod/api/server/v2/generated/model/types.go

Line 858 in ebcd07b

type BoxResponse = Box

[jasonpaulos]

No, this makes sense here. The schema ref that BoxResponse uses means it's really just an alias to Box. See our generated type here:

go-algorand/daemon/algod/api/server/v2/generated/model/types.go

Line 858 in ebcd07b

type BoxResponse = Box

[jasonpaulos]

Nicely done