New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algod: Simulation PC exposure for App approval/clear-state transaction #5360
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5360 +/- ##
==========================================
+ Coverage 55.31% 55.32% +0.01%
==========================================
Files 452 452
Lines 63844 63936 +92
==========================================
+ Hits 35313 35372 +59
- Misses 26101 26132 +31
- Partials 2430 2432 +2
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b820620
to
084a701
Compare
084a701
to
e594ff6
Compare
ccb4db3
to
c67d3a2
Compare
62d8194
to
e7eae8e
Compare
e437810
to
8fbe1fd
Compare
fba377e
to
4aadd90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking quite close. I mostly have some concerns about naming, and whether we can simplify the interface between "internal" structs and models. I may well be wrong about how pointers are handled in serialization. I think @jasonpaulos is a bit of an expert here.
54c7135
to
dcdac1f
Compare
a99671b
to
9640723
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending tests, looks good
algorand#5360) Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
Summary
This PR implements #5012, which exposes PC during simulation for each txn-group.
Test Plan
simulation_eval_test.go
:a. recursive inner calls that creates app, calls app and deletes itself.
b. app-call transaction approved through a logic sig.
c. a vanilla app-call transaction together with extra budget supply.
restClient.go
:a. an e2e test that tests recursive inner calls that creates app, calls app and deletes itself. See if trace work as expected