Tests: Fix error messages in ledger tests #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id-ms
force-pushed
the
fix-error-messages-in-ledger-tests
branch
from
cbdb050
to
8599cbe
Compare
Codecov Report
@@ Coverage Diff @@
## master #5363 +/- ##
==========================================
+ Coverage 55.28% 55.29% +0.01%
==========================================
Files 454 454
Lines 63772 63772
==========================================
+ Hits 35254 35265 +11
+ Misses 26115 26106 -9
+ Partials 2403 2401 -2 see 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
May 8, 2023
bbroder-algo
approved these changes
May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some of the ledger unit test does not add the block to the mock block queue and only invokes
newBlockon all trackers. This causes the voters tracker to fail since it relays on data from the block queue.In order to fix it, just need to make sure that blocks are added to the mock block queue
Test Plan