Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algod: Add EvalTracer tests for StateDeltas #5368

Merged

Conversation

jasonpaulos
Copy link
Member

@jasonpaulos jasonpaulos commented May 8, 2023

Summary

Offshoot from #5234. This PR contains the same StateDeltas improvements and additional EvalTracer test coverage for changes introduced in #5297, but it does not implement per-transaction StateDelta reporting.

Test Plan

This is primarily a testing PR.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #5368 (a867d5a) into master (d7c5e54) will decrease coverage by 0.04%.
The diff coverage is 51.85%.

@@            Coverage Diff             @@
##           master    #5368      +/-   ##
==========================================
- Coverage   55.41%   55.38%   -0.04%     
==========================================
  Files         452      452              
  Lines       63643    63685      +42     
==========================================
+ Hits        35270    35271       +1     
- Misses      25972    25988      +16     
- Partials     2401     2426      +25     
Impacted Files Coverage Δ
ledger/simulation/trace.go 90.24% <ø> (ø)
ledger/ledgercore/statedelta.go 30.57% <51.85%> (+7.60%) ⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasonpaulos jasonpaulos marked this pull request as ready for review May 9, 2023 18:37
bbroder-algo
bbroder-algo previously approved these changes May 10, 2023
data/transactions/logic/mocktracer/tracer.go Show resolved Hide resolved
data/transactions/logic/mocktracer/tracer.go Outdated Show resolved Hide resolved
ledger/ledgercore/statedelta.go Outdated Show resolved Hide resolved
ledger/ledgercore/statedelta.go Outdated Show resolved Hide resolved
@bbroder-algo bbroder-algo merged commit 377d724 into algorand:master May 13, 2023
24 checks passed
@jasonpaulos jasonpaulos deleted the eval-tracer-state-deltas-tests branch May 15, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants