ledger: Exclude stake at R-320 that is expired by R #5403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a DB method to calculate the total expired stake registered at rnd that is expired by voteRnd. It adds a consensus check to the ledger implementation of the Circulation(rnd) call that agreement makes, which in turn calls onlineAccounts.onlineTotals. If ExcludeExpiredCirculation is set, it subtracts expired stake at rnd+320 from the total online stake at rnd. Details: * when the next round is going to be round R, a proposal/vote will come in for round R (or some other trigger we could add) * query the DB's onlineaccounts table looking for accounts online at R that are expired in any round before R+320 (this using the "updated as of rnd" and "expired by rnd" indexes) * sum up the expired online stake for these accounts * subtract expired stake from total online stake and put in cache to use for all votes seen for R Co-authored-by: Pavel Zbitskiy <65323360+algorandskiy@users.noreply.github.com>
winder
approved these changes
May 19, 2023
winder
reviewed
May 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #5403 +/- ##
==========================================
- Coverage 55.42% 54.43% -1.00%
==========================================
Files 452 452
Lines 63689 63812 +123
==========================================
- Hits 35302 34733 -569
- Misses 25972 26603 +631
- Partials 2415 2476 +61
... and 65 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
reviewed
May 19, 2023
Comment on lines
+43
to
+51
| type simpleLedgerOption func(*simpleLedgerCfg) | ||
|
|
||
| func simpleLedgerOnDisk() simpleLedgerOption { | ||
| return func(cfg *simpleLedgerCfg) { cfg.onDisk = true } | ||
| } | ||
|
|
||
| func simpleLedgerNotArchival() simpleLedgerOption { | ||
| return func(cfg *simpleLedgerCfg) { cfg.notArchival = true } | ||
| } |
gmalouf
approved these changes
May 19, 2023
bbroder-algo
approved these changes
May 19, 2023
There was a problem hiding this comment.
This patch removes expired voting stake totals from the total online stake for the agreement implementation. It adds a table scan and a sort of the onlineaccounts table to the calculation, and includes a lock-held synchronization check to guard against asynchronous DB advancement.
tzaffi
pushed a commit
to tzaffi/go-algorand
that referenced
this pull request
May 22, 2023
wip netdeploy: Copy ledger directory for kv tracker database (algorand#5392) assembler: Error if extra args are present in pragmas (algorand#5400) ledger: Exclude stake at R-320 that is expired by R (algorand#5403) Co-authored-by: cce <51567+cce@users.noreply.github.com> algod: Don't return a top level array from algod (algorand#5404) revert go get github.com/algorand/msgp@v1.1.53 go get github.com/getkin/kin-openapi@v0.107.0 go mod tidy -compat=1.17 go get github.com/algorand/msgp@v1.1.50 go mod tidy -compat=1.17 go get github.com/algorand/msgp@v1.1.50 revert to master github.com/getkin/kin-openapi v0.117.0 github.com/getkin/kin-openapi v0.117.0 github.com/getkin/kin-openapi v0.117.0 go get golang.org/x/mod/modfile tidy #0 go get github.com/algorand/msgp@v1.1.53 go mod tidy tidy up after every go get simplify revert tidier tg tg
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a DB method to calculate the total expired stake registered at rnd that is expired by voteRnd.
It adds a consensus check to the ledger implementation of the Circulation(rnd) call that agreement makes, which in turn calls onlineAccounts.onlineTotals. If ExcludeExpiredCirculation is set, it subtracts expired stake at rnd+320 from the total online stake at rnd.
Details:
Test Plan
New unit tests added