Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal: rename --allow-extra-opcode-budget to --allow-more-opcode-budget #5407

Merged

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented May 22, 2023

Summary

For the sake of uniformity, we rename --allow-extra-opcode-budget to --allow-more-opcode-budget, to align with --allow-more-logging.

Test Plan

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #5407 (4bb2f88) into master (a497df0) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #5407      +/-   ##
==========================================
- Coverage   55.39%   55.38%   -0.01%     
==========================================
  Files         452      452              
  Lines       63816    63815       -1     
==========================================
- Hits        35350    35344       -6     
- Misses      26038    26040       +2     
- Partials     2428     2431       +3     
Impacted Files Coverage Δ
cmd/goal/clerk.go 8.83% <33.33%> (+0.01%) ⬆️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahangsu ahangsu marked this pull request as ready for review May 22, 2023 16:52
@bbroder-algo
Copy link
Contributor

idk...

Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't need to change the oas2 this is a relatively small change, so seems fine to me.

@ahangsu
Copy link
Contributor Author

ahangsu commented May 23, 2023

we missed the boat... adios

we still get the boat!

@ahangsu ahangsu closed this May 23, 2023
@ahangsu ahangsu deleted the rename-extra-to-more-on-budget branch May 23, 2023 20:12
@ahangsu ahangsu restored the rename-extra-to-more-on-budget branch May 24, 2023 19:01
@ahangsu ahangsu reopened this May 24, 2023
@ahangsu ahangsu requested a review from jannotti May 24, 2023 19:09
@bbroder-algo bbroder-algo merged commit 058a9d5 into algorand:master May 24, 2023
33 of 34 checks passed
@ahangsu ahangsu deleted the rename-extra-to-more-on-budget branch May 24, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants