-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goal: rename --allow-extra-opcode-budget
to --allow-more-opcode-budget
#5407
Goal: rename --allow-extra-opcode-budget
to --allow-more-opcode-budget
#5407
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5407 +/- ##
==========================================
- Coverage 55.39% 55.38% -0.01%
==========================================
Files 452 452
Lines 63816 63815 -1
==========================================
- Hits 35350 35344 -6
- Misses 26038 26040 +2
- Partials 2428 2431 +3
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
idk... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't need to change the oas2 this is a relatively small change, so seems fine to me.
we still get the boat! |
Summary
For the sake of uniformity, we rename
--allow-extra-opcode-budget
to--allow-more-opcode-budget
, to align with--allow-more-logging
.Test Plan