AVM: Make apps and app accounts available while creation is "pending" #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in the same consensus version that allows resource sharing, this PR makes apps and app accounts of "pending" app creates available while their inners are executing. This was the intent all along, the new app was only added to `cx.createdApps` at the conclusion of its execution, rather than at the start.
jannotti
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5425 +/- ##
=======================================
Coverage 55.37% 55.37%
=======================================
Files 447 447
Lines 63226 63233 +7
=======================================
+ Hits 35011 35018 +7
+ Misses 25823 25819 -4
- Partials 2392 2396 +4
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
previously approved these changes
May 30, 2023
algorandskiy
approved these changes
May 30, 2023
jasonpaulos
reviewed
May 30, 2023
jasonpaulos
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in the same consensus version that allows resource sharing, this PR makes apps and app accounts of "pending" app creates available while their inners are executing.
This was the intent all along, but the new app was only added to
cx.createdAppsat the conclusion of its execution, rather than at the start.Test Plan
Existing tests, plus some new ones that test that that holdings of the app account, and globals are accessible in inners of the create.