Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: don't use deprecated set-output in github actions #5453

Merged

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented Jun 6, 2023

Summary

Github Action's set-output command is deprecated as I discovered when looking closer at the results of the Test tools modules workflow added in #5381 .
I'm replacing this usage by saving / reading from GA's env var file $GITHUB_ENV

Test Plan

CI

We can verify that everything's still running via this intentional test fail.

@tzaffi tzaffi self-assigned this Jun 6, 2023
@tzaffi tzaffi added the Bug-Fix label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #5453 (0aa568d) into master (1994341) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5453      +/-   ##
==========================================
+ Coverage   55.47%   55.50%   +0.03%     
==========================================
  Files         447      447              
  Lines       63290    63290              
==========================================
+ Hits        35108    35127      +19     
+ Misses      25800    25788      -12     
+ Partials     2382     2375       -7     

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tzaffi tzaffi marked this pull request as ready for review June 6, 2023 05:00
@tzaffi tzaffi requested a review from a team as a code owner June 6, 2023 05:00
@tzaffi tzaffi requested review from excalq and algobarb June 6, 2023 05:00
@cce cce changed the title bugfix: don't use deprecated set-output in github actions CI: don't use deprecated set-output in github actions Jun 6, 2023
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. LGTM

@algorandskiy algorandskiy merged commit 6b712a1 into algorand:master Jun 6, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants