Build: Golang 1.20 upgrade. #5462
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5462 +/- ##
==========================================
- Coverage 55.63% 51.07% -4.56%
==========================================
Files 447 447
Lines 63405 63401 -4
==========================================
- Hits 35274 32384 -2890
- Misses 25751 28542 +2791
- Partials 2380 2475 +95
... and 147 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Also look at bumping https://github.com/algorand/go-algorand/blob/master/scripts/buildtools/versions for golangci-lint and golang.org/x/tools, perhaps gotestsum too |
Yeah, had bumped golangci-lint locally, been spending time putting in excludes or fixing minor issues. |
.golangci.yml
Outdated
| confidence: 0.8 | ||
|
|
||
| # In order to disable any default rules, you have to list out all rules you would like enabled. | ||
| # We explicitly disable (vs omitting) rules to make it clear how we are diverging. |
There was a problem hiding this comment.
Why not just add the ones we don't like to the exclude-rules section below? It seems like less work than checking the revive default rules list periodically to see if it changed?
There was a problem hiding this comment.
I wasn't clear you could finetune revive's sub-rules in exclude-rules and saw multiple PR discussions laying out that going off the beaten path overrode golangci's default config for revive (requiring a full lay out like so).
There was a problem hiding this comment.
Would you be willing to pull cce@a167659 ?
gmalouf
force-pushed
the
golang-v20-upgrade
branch
from
384c865
to
4896d8d
Compare
|
it looks ok to me gary |
Summary
Exactly what it sounds like; upgrade go-algorand to compile with Golang 1.20.5.
Note: Upon merge, developers need to re-run
./scripts/buildtools/install_buildtools.shto get updated versions of our buildtools.Test Plan
Existing unit/functional/integration tests all pass. Builds (on PR, nightly, etc) all function as intended.