Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genesis: add GenesisAccountData type for use in GenesisAllocation #5463

Merged
merged 3 commits into from Jun 13, 2023

Conversation

cce
Copy link
Contributor

@cce cce commented Jun 9, 2023

Summary

Alternate for #5447 that specifies the narrow set of fields allowed in the GenesisAllocation (the "alloc" part of the genesis.json file).

#5316

Test Plan

Existing tests updated, should pass

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #5463 (92ac71f) into master (fd60def) will decrease coverage by 0.02%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master    #5463      +/-   ##
==========================================
- Coverage   55.57%   55.56%   -0.02%     
==========================================
  Files         447      447              
  Lines       63356    63366      +10     
==========================================
- Hits        35213    35209       -4     
- Misses      25772    25780       +8     
- Partials     2371     2377       +6     
Impacted Files Coverage Δ
netdeploy/remote/deployedNetwork.go 18.58% <0.00%> (ø)
data/bookkeeping/genesis.go 35.36% <100.00%> (+8.97%) ⬆️
gen/generate.go 66.66% <100.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cce cce added the Enhancement label Jun 9, 2023
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good - I'm also slowly in favor of a less intrusive and isolated change in favor of #5447, especially since data in the genesis file should rarely change.

@algochoi algochoi requested review from tzaffi and winder June 12, 2023 21:15
@winder winder merged commit 8ab4aad into algorand:master Jun 13, 2023
25 checks passed
@cce cce deleted the add-GenesisAccountData branch June 14, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants