New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: replace upload_metrics #5470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5470 +/- ##
==========================================
- Coverage 55.60% 46.47% -9.14%
==========================================
Files 447 447
Lines 63395 63395
==========================================
- Hits 35253 29461 -5792
- Misses 25760 31425 +5665
- Partials 2382 2509 +127 see 203 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as none of my proposed changes have any impact on function.
table_header = ( | ||
f"Scenario,Conduit_Version,{args.database_description}" | ||
) | ||
print(table_header) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
table_header = ( | |
f"Scenario,Conduit_Version,{args.database_description}" | |
) | |
print(table_header) | |
print(f"Scenario,Conduit_Version,{args.database_description}") |
ignoreable nit
return data | ||
|
||
|
||
def pretty_print(data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend a comment here explaining the conventions:
"""
* scenario config files with "sm" in their name are assumed to have `TXN_PER_BLOCK_SM` transactions per block
* scenario config files with "jumbo" in their names are assumed to have `TXN_PER_BLOCK_JUMBO` transactions per block
* others are assumed to have `TXN_PER_BLOCK` transactions per block
"""
for d in data: | ||
scenario = d["scenario"].split("config.")[1] | ||
scenario_parsed = scenario.split(".yml")[0] | ||
txn_per_block = TXN_PER_BLOCK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is an issue, but just noting the fact that I'm about to change this exactness of these numbers going forward. For example, formerly the small scenarios had exactly TXN_PER_BLOCK_SM
(100) but now they may have
adding a python script to print TPS from the block generator reports to stdout. the output is formatted in a way that can be copied and pasted to google sheets to create bar charts.
And we decided not to use datadog for displaying the perf results; removing upload_metrics script.
output: