Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding: Update go-codec version. #5471

Merged
merged 1 commit into from Jun 16, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jun 15, 2023

Summary

Update go-codec to latest version. Mainly for consistency, the upstream change has extremely limited (or no) functional impact to go-algorand code at the API layer.

Test Plan

Existing unit tests.

@winder winder requested review from cce and jasonpaulos June 15, 2023 12:07
@winder winder self-assigned this Jun 15, 2023
@winder winder marked this pull request as ready for review June 15, 2023 12:24
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #5471 (292593f) into master (79697d5) will increase coverage by 2.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5471      +/-   ##
==========================================
+ Coverage   53.22%   55.63%   +2.41%     
==========================================
  Files         447      447              
  Lines       63414    63414              
==========================================
+ Hits        33752    35281    +1529     
+ Misses      27264    25753    -1511     
+ Partials     2398     2380      -18     

see 103 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@algorandskiy algorandskiy merged commit 05f1c72 into algorand:master Jun 16, 2023
29 checks passed
@winder winder deleted the will/go-codec-dep branch June 16, 2023 16:02
iansuvak pushed a commit to iansuvak/go-algorand that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants