Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: block generator apps. Part 2: boxes #5478
tools: block generator apps. Part 2: boxes #5478
Changes from all commits
fbdfafb
8d9d6cc
6dcf417
aee29e3
ae6d910
480a00d
53c4960
676db87
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these configurable? I believe the
TxTypeID
was previously used for the different types of transactions that would be chosen according to the ratios. This seems more like something that would be inGenerationConfig
liketx_per_block
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right that it's better to keep
TxTypeID
for types of transactions that can actually be chosen. I'll work to carve out a separate types for these effects.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, one issue here is that I do need to record the effects and these get stored in a
type Report map[TxTypeID]TxData
whose key is of typeTxTypeID
. So it does complicates things a bit. If we relaxReport
to have keys of typestring
, I still ought to be able to separate it out. I'll keep you posted.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original concern will be addressed in a follow up PR. Here's a commit: tzaffi@291d30f