Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use exp/slices and exp/maps to simplify some code #5479

Merged
merged 13 commits into from
Jun 22, 2023

Commits on Jun 21, 2023

  1. Use exp/slices and exp/maps to simplify some code

    The intent is to only make changes where the result is clearer, and to
    catch enough cases that the next time someone does something similar,
    they will have seen the new, clearer way to write the thing they intend.
    jannotti committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5c1bedc View commit details
    Browse the repository at this point in the history
  2. Use maps.Clear

    jannotti committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    9192bc4 View commit details
    Browse the repository at this point in the history
  3. dead code

    jannotti committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    43ffe44 View commit details
    Browse the repository at this point in the history
  4. another clone

    jannotti committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    6e40ea0 View commit details
    Browse the repository at this point in the history
  5. slices.Index and deadcode

    jannotti committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    25ceeb3 View commit details
    Browse the repository at this point in the history
  6. maps.Equal

    jannotti committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ef29274 View commit details
    Browse the repository at this point in the history
  7. Never use strings.Compare

    NOTE(rsc): This function does NOT call the runtime cmpstring function,
    because we do not want to provide any performance justification for
    using strings.Compare. Basically no one should use strings.Compare.
    jannotti committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0e20408 View commit details
    Browse the repository at this point in the history
  8. The easier CR fixes from jasonpaulos.

    Need to do a little gitting around for the memory optimzation reversion.
    jannotti committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    b2d40d9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    34ee175 View commit details
    Browse the repository at this point in the history
  10. new -> newMap

    jannotti committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    49b4704 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f067653 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. remove a couple one-liners

    jannotti committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    025be8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4244a0 View commit details
    Browse the repository at this point in the history