Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algocfg: Add EnableTxnEvalTracer to algocfg development profile. #5481

Merged
merged 1 commit into from Jun 23, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jun 20, 2023

Summary

Update algocfg development profile to set:

MaxAcctLookback = 256
EnableTxnEvalTracer = true

Test Plan

Run algocfg profile set development -d . and confirm the expected config file is created.

@winder winder requested review from Eric-Warehime and a team June 20, 2023 13:04
@winder winder self-assigned this Jun 20, 2023
@winder winder changed the title Add EnableTxnEvalTracer to algocfg development profile. algocfg: Add EnableTxnEvalTracer to algocfg development profile. Jun 20, 2023
@winder winder marked this pull request as ready for review June 20, 2023 15:43
@algorandskiy
Copy link
Contributor

Please rebase/merge the master in - all known go1.20 build issues fixed there

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #5481 (1bf69ee) into master (f514d82) will decrease coverage by 6.42%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5481      +/-   ##
==========================================
- Coverage   55.63%   49.21%   -6.42%     
==========================================
  Files         446      446              
  Lines       63153    79475   +16322     
==========================================
+ Hits        35137    39116    +3979     
- Misses      25645    37987   +12342     
- Partials     2371     2372       +1     
Impacted Files Coverage Δ
cmd/algocfg/profileCommand.go 25.67% <0.00%> (-4.02%) ⬇️

... and 416 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit f56b9bd into algorand:master Jun 23, 2023
17 checks passed
@winder winder deleted the will/dev-defaults branch June 23, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants