Build: Split nightly job into its own workflow. Remove ARM64 platform builds from our triggered/on commit builds. #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from our triggered/on commit builds.
onetechnical
requested changes
Jun 21, 2023
|
The test restrictions are just for PRs, and because you're leaving the name circleci_build_and_test I think PRs to master work as is. rel/nightly doesn't have this (no PRs for rel/nightly), so we'll just have to update the restriction on rel/beta and rel/stable once it's getting merged out to them. |
Co-authored-by: John Lee <john@onetechnical.com>
Codecov Report
@@ Coverage Diff @@
## master #5485 +/- ##
==========================================
- Coverage 55.64% 47.66% -7.99%
==========================================
Files 448 448
Lines 63493 63493
==========================================
- Hits 35328 30261 -5067
- Misses 25772 30740 +4968
- Partials 2393 2492 +99 see 200 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
onetechnical
approved these changes
Jun 21, 2023
algobarb
reviewed
Jun 21, 2023
| context: | ||
| - slack-secrets | ||
| - aws-secrets | ||
| <<: *slack-fail-post-step | ||
|
|
||
| #- windows_x64_build | ||
| "circleci_build_and_test": |
There was a problem hiding this comment.
we can probably remove the quotes here then too
algobarb
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For reducing build times, improving developer workflows and some optimizations, we are moving ARM64 builds to be solely nightly jobs. As a part of this PR, we separated the nightly runs into their own dedicated workflow for easier identification/cost management.
Test Plan
Run nightly builds - check running of triggered builds.