CI: Don't run tests during benchmark #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5491 +/- ##
==========================================
- Coverage 55.70% 55.68% -0.03%
==========================================
Files 446 446
Lines 63291 63291
==========================================
- Hits 35259 35244 -15
- Misses 25662 25674 +12
- Partials 2370 2373 +3 see 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algobarb
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that our benchmark job also runs all unit tests in the logic package.
Not only is this unnecessary, it also causes the benchmark job to fail if there are unrelated test failures in that package, which I found confusing during development. See here for an example: https://github.com/algorand/go-algorand/actions/runs/5340633710/jobs/9680667023
The solution is pretty simple, we just need to filter out all tests, which I've done by adding the
-run=^$flag.Test Plan
n/a