Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algocfg: Remove block validation override from participation profile. #5502

Merged
merged 1 commit into from Jun 27, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jun 27, 2023

Summary

The default CatchupBlockValidationMode value is sufficient for participation.

@winder winder self-assigned this Jun 27, 2023
@winder winder changed the title Remove block validation override from participation profile. algocfg: Remove block validation override from participation profile. Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #5502 (0f3d3a5) into master (df22f75) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5502      +/-   ##
==========================================
- Coverage   55.82%   55.77%   -0.05%     
==========================================
  Files         446      446              
  Lines       63224    63223       -1     
==========================================
- Hits        35292    35260      -32     
- Misses      25565    25590      +25     
- Partials     2367     2373       +6     
Impacted Files Coverage Δ
cmd/algocfg/profileCommand.go 29.23% <ø> (+0.44%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review June 27, 2023 13:27
@winder winder requested a review from cce June 27, 2023 13:46
@winder winder merged commit 6d7913c into algorand:master Jun 27, 2023
17 of 20 checks passed
@winder winder deleted the will/change-participation-profile branch June 27, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants