Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Start kmd in the background. #5514

Merged
merged 2 commits into from Jun 30, 2023
Merged

Conversation

winder
Copy link
Contributor

@winder winder commented Jun 28, 2023

Summary

The user is left out intentionally, see #5464

This doesn't fix the root issue where it takes 30 seconds for kmd to start, but should allow it to startup without delay.

Test Plan

Test against rel/stable and this PR branch:

docker build \
             -t wwinder/algod:exec \
             --build-arg CHANNEL=stable \
             --build-arg TARGETARCH=amd64 --no-cache \
             .
docker run --rm -it \
             -e START_KMD=1 \
             --name algod-test-run \
             -v (pwd)/docker_data_dir:/algod/data \
             wwinder/algod:exec

on rel/stable it takes 30 seconds to startup due to kmd locking the pidfile, which is due to the user being managed incorrectly with exec and runuser.

With this branch it starts in less than 5 seconds.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #5514 (1606372) into master (68ebeb5) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5514      +/-   ##
==========================================
- Coverage   55.78%   55.77%   -0.02%     
==========================================
  Files         446      446              
  Lines       63228    63228              
==========================================
- Hits        35271    35264       -7     
- Misses      25585    25596      +11     
+ Partials     2372     2368       -4     

see 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shiqizng
shiqizng previously approved these changes Jun 28, 2023
@winder winder added the Bug-Fix label Jun 29, 2023
@winder winder changed the title Start kmd in the background. docker: Start kmd in the background. Jun 29, 2023
@winder winder self-assigned this Jun 29, 2023
@winder winder marked this pull request as ready for review June 30, 2023 17:52
@shiqizng shiqizng requested a review from a team June 30, 2023 18:21
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs as expected and starts up without delay on my machine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants