follower: Use Buffered syncNow channel to correctly trigger sync in private networks #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5516 +/- ##
=======================================
Coverage 55.78% 55.78%
=======================================
Files 446 446
Lines 63228 63227 -1
=======================================
+ Hits 35271 35273 +2
+ Misses 25585 25579 -6
- Partials 2372 2375 +3
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
reviewed
Jun 29, 2023
Eric-Warehime
approved these changes
Jun 29, 2023
winder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Importing blocks from a follower node lags behind in sandbox due to frequent timeouts when trying to sync the ledger. This PR changes the
syncNowchannel to a buffered channel to trigger resyncs properly in sandbox.algorand/conduit#102
Test Plan
Existing tests should suffice and checked on sandbox that conduit syncs quickly.