New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rest api: Allow fast track transaction broadcasting via txHandler #5535
rest api: Allow fast track transaction broadcasting via txHandler #5535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be a new endpoint that isn't exposed to the public API / SDKs? I believe tagging it "experimental" will opt it out of the downstream code generation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. LGTM.
Codecov Report
@@ Coverage Diff @@
## master #5535 +/- ##
==========================================
- Coverage 54.94% 54.93% -0.01%
==========================================
Files 463 463
Lines 64476 64515 +39
==========================================
+ Hits 35427 35444 +17
- Misses 26668 26692 +24
+ Partials 2381 2379 -2
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
merged master and regenerated routes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See cce's comment about the function naming being somewhat confusing, but this appears to be the same as when I previously approved.
* Add a new RawTransactionAsync experimental endpoint
1a26a3a
to
d57fc52
Compare
rebased master |
d57fc52
to
f8ac06c
Compare
Summary
Added a new
RawTransactionsAsync
handler (enabled with ExperimentalAPI) that shortcuts to non-blocking txHandler call. This is useful for local pingpong high TPS testing. (Although real high TPS is still blocked by Echo's logging middleware, but this is a separate topic).This handler is used in pingpong via libgoal.
Also set
EnableExperimentalAPI=true
for local network templates and scenario1s.Test Plan
Tested locally with pingpong, 2.5 TPS observed out of 3k requested - here are the data for 2m run: