p2p: multiaddr dns bootstrapping utils #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5575 +/- ##
==========================================
+ Coverage 54.95% 54.99% +0.04%
==========================================
Files 463 465 +2
Lines 64525 64584 +59
==========================================
+ Hits 35457 35521 +64
+ Misses 26684 26682 -2
+ Partials 2384 2381 -3
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
reviewed
Jul 18, 2023
shiqizng
reviewed
Jul 19, 2023
shiqizng
previously approved these changes
Jul 26, 2023
iansuvak
previously approved these changes
Jul 27, 2023
winder
previously approved these changes
Jul 28, 2023
cce
reviewed
Jul 31, 2023
cce
approved these changes
Aug 1, 2023
iansuvak
approved these changes
Aug 1, 2023
winder
approved these changes
Aug 1, 2023
This was referenced Aug 17, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initial set of changes which integrate with our ResolveController to fetch multiaddrs from TXT records in the dnsaddr format.
Test Plan
Unit tests for now. Also working on building out the
algonsfunctionality to setup network bootstraps via dns.Info
Resolves #5545