Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to go1.20.6 #5577

Merged
merged 3 commits into from Aug 10, 2023
Merged

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Jul 18, 2023

Summary

  1. use go1.20.6
  2. revert go-expermiments disabling

Test Plan

Local runs showed no perf difference.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #5577 (1e531eb) into master (d316914) will decrease coverage by 0.03%.
Report is 34 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5577      +/-   ##
==========================================
- Coverage   55.79%   55.76%   -0.03%     
==========================================
  Files         446      446              
  Lines       63418    63418              
==========================================
- Hits        35381    35365      -16     
- Misses      25668    25681      +13     
- Partials     2369     2372       +3     

see 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cce
cce previously approved these changes Jul 21, 2023
@cce
Copy link
Contributor

cce commented Jul 21, 2023

You also have to upgrade the versions in .github/workflows

@algobarb
Copy link
Contributor

algobarb commented Jul 21, 2023

Maybe it needs to be run once with line 62 set to if: steps.cache-golangci-lint.outputs.cache-hit == 'true' in .github/workflows/reviewdog.yml. Then it will update the cache and afterwards, you can revert the change. (EDIT: or maybe the versions in .github/workflows/reviewdog.yml just need to be updated)

@algorandskiy algorandskiy changed the title WIP: upgrade to go1.20.6 build: upgrade to go1.20.6 Aug 7, 2023
@algorandskiy algorandskiy marked this pull request as ready for review August 7, 2023 18:26
@algorandskiy algorandskiy requested a review from a team as a code owner August 7, 2023 18:26
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@algorandskiy algorandskiy merged commit 435532d into algorand:master Aug 10, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants