tools: let catchpointdump to calculate and print data hashes #5584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
force-pushed
the
pavel/catchpointdump-hashes
branch
from
97a8514
to
82dd5ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #5584 +/- ##
==========================================
- Coverage 55.79% 55.77% -0.02%
==========================================
Files 446 446
Lines 63418 63428 +10
==========================================
- Hits 35381 35374 -7
- Misses 25668 25687 +19
+ Partials 2369 2367 -2
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlgoAxel
approved these changes
Jul 20, 2023
| @@ -76,6 +77,11 @@ func (m *catchpointCatchupAccessorMock) Ledger() (l ledger.CatchupAccessorClient | |||
| return m.l | |||
| } | |||
|
|
|||
| // GetVerifyData returns the balances hash, spver hash and totals used by VerifyCatchpoint | |||
There was a problem hiding this comment.
This comment appears copy/paste from the real impl, may want to just mention that this is a stub to satisfy the interface.
| @@ -67,6 +69,11 @@ func (m *MockCatchpointCatchupAccessor) GetCatchupBlockRound(ctx context.Context | |||
| return basics.Round(0), nil | |||
| } | |||
|
|
|||
| // GetVerifyData returns the balances hash, spver hash and totals used by VerifyCatchpoint | |||
There was a problem hiding this comment.
This comment appears copy/paste from the real impl, may want to just mention that this is a stub to satisfy the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Tested manually