Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: Update macos xcode versions #5590

Merged
merged 15 commits into from Jul 20, 2023
Merged

Conversation

algobarb
Copy link
Contributor

@algobarb algobarb commented Jul 20, 2023

Summary

  • CircleCI is deprecating the medium and large macos resource classes. Instead we are replacing it with macos.x86.medium.gen2. There is no equivalent of large except for macos.m1.large.gen1 but it's an M1 machine and not an amd macos. It's also much more expensive.
  • Changed the M1 self-hosted runner name to resource_class: algorand/macstadium-m1

Test Plan

scripts/configure_dev.sh change
    # Change the conditional from != to == once and then revert back
    if [ "${CIRCLECI}" == "true" ]; then
        install_or_upgrade jq
        install_or_upgrade autoconf
        install_or_upgrade automake
        install_or_upgrade python3
        install_or_upgrade lnav
        install_or_upgrade diffutils
        lnav -i "$SCRIPTPATH/algorand_node_log.json"
    fi

@algobarb algobarb self-assigned this Jul 20, 2023
@algobarb algobarb marked this pull request as ready for review July 20, 2023 21:54
@algobarb algobarb requested a review from a team as a code owner July 20, 2023 21:54
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5590 (94a1bfe) into master (d316914) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5590      +/-   ##
==========================================
- Coverage   55.79%   55.77%   -0.02%     
==========================================
  Files         446      446              
  Lines       63418    63418              
==========================================
- Hits        35381    35373       -8     
- Misses      25668    25676       +8     
  Partials     2369     2369              

see 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbroder-algo bbroder-algo merged commit 548399e into master Jul 20, 2023
21 checks passed
@winder winder deleted the algobarb/updateCircleCI branch July 20, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants