p2p: Add peerID and feature flag #5591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5591 +/- ##
==========================================
+ Coverage 54.97% 54.99% +0.02%
==========================================
Files 462 463 +1
Lines 64490 64515 +25
==========================================
+ Hits 35456 35483 +27
- Misses 26659 26661 +2
+ Partials 2375 2371 -4
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eric-Warehime
commented
Jul 21, 2023
winder
reviewed
Jul 21, 2023
winder
reviewed
Jul 21, 2023
winder
suggested changes
Jul 21, 2023
Eric-Warehime
changed the title
shiqizng
reviewed
Jul 26, 2023
shiqizng
previously approved these changes
Jul 26, 2023
winder
previously approved these changes
Jul 27, 2023
iansuvak
previously approved these changes
Jul 27, 2023
Eric-Warehime
dismissed stale reviews from iansuvak, winder, and shiqizng
via
ad0a831
shiqizng
approved these changes
Jul 28, 2023
iansuvak
approved these changes
Jul 28, 2023
algorandskiy
approved these changes
Jul 28, 2023
This was referenced Aug 17, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds some defaults for generating and loading peer IDs. Only supporting ed25519 which is one of the standard algorithms supported by libp2p.
Also adds some config options for enabling p2p in general and how to locate peerID keys.
Test Plan
Unit tests for now can simulate most of the behavior we care about w/ temp directories. Usage of the private key as peer ID will be further exercised once it's used in the host implementation.
Info
Closes #5580, Closes #5581