catchpoint: use read connection for data retrieval for spver hash calculation #5592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5592 +/- ##
==========================================
- Coverage 55.82% 55.75% -0.07%
==========================================
Files 446 446
Lines 63482 63482
==========================================
- Hits 35437 35395 -42
- Misses 25675 25712 +37
- Partials 2370 2375 +5
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Jul 21, 2023
AlgoAxel
approved these changes
Jul 21, 2023
algorandskiy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#5579 was merged a few minutes before I had a chance to push this commit to address @AlgoAxel's PR feedback in #5579 (comment) about using read vs write scopes for getting the SP verification context. This is that change
Test Plan
Existing tests should pass.