goal: --full-trace keeps track of everything in exec trace
#5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5609 +/- ##
==========================================
- Coverage 54.99% 54.54% -0.45%
==========================================
Files 460 460
Lines 64439 64446 +7
==========================================
- Hits 35436 35154 -282
- Misses 26637 26903 +266
- Partials 2366 2389 +23
... and 31 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
reviewed
Jul 26, 2023
jasonpaulos
approved these changes
Jul 26, 2023
bbroder-algo
approved these changes
Jul 26, 2023
bbroder-algo
changed the title
--all-trace-options keeps track of everything in exec trace--full-trace keeps track of everything in exec trace
This was referenced Aug 17, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a discussion, we found it helpful to define a handy "activate all" option for exec trace in
goal clerk simulate, this PR provides a straight-forward implementation.Test Plan
modified a line in e2e test with the new option, should go through with stack changes and scratch slot changes.