New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
algod: Add API Endpoint to fetch TxIDs from block #5611
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5611 +/- ##
=======================================
Coverage 54.95% 54.96%
=======================================
Files 463 463
Lines 64553 64570 +17
=======================================
+ Hits 35478 35491 +13
- Misses 26698 26707 +9
+ Partials 2377 2372 -5
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking clean and correct.
I left a couple of nits. Also consider adding a call to the endpoint in an already existing E2E test. But this might entail adding a local client (not too bad).
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining for Pavel's feedback
Summary
Adds an algod endpoint
/v2/blocks/{round}/txids
to return top level TxIDs in a given block.#5461
Test Plan
Added a unit test in
handlers_test.go
, added a small test in an existing e2e test and locally tested endpoint to confirm that only top-level txids were reported.