tests: fix close - commit data race in tracker tests

[algorandskiy]

Summary

Fixed data race from this build:

WARNING: DATA RACE
Read at 0x00c000144900 by goroutine 3010:
  runtime.mapaccess1()
      /opt/cibuild/.gimme/versions/go1.20.5.linux.amd64/src/runtime/map.go:395 +0x0
  github.com/algorand/go-algorand/ledger.(*lruAccounts).read()
      /opt/cibuild/project/ledger/lruaccts.go:66 +0x97
  github.com/algorand/go-algorand/ledger.makeCompactAccountDeltas()
      /opt/cibuild/project/ledger/acctdeltas.go:453 +0x878
  github.com/algorand/go-algorand/ledger.(*accountUpdates).prepareCommit()
      /opt/cibuild/project/ledger/acctupdates.go:1555 +0x688
  github.com/algorand/go-algorand/ledger.(*trackerRegistry).commitRound()
      /opt/cibuild/project/ledger/tracker.go:538 +0x641
  github.com/algorand/go-algorand/ledger.(*trackerRegistry).commitSyncer()
      /opt/cibuild/project/ledger/tracker.go:480 +0x20d
  github.com/algorand/go-algorand/ledger.(*trackerRegistry).initialize.func2()
      /opt/cibuild/project/ledger/tracker.go:308 +0x47

Previous write at 0x00c000144900 by goroutine 2978:
  runtime.mapdelete()
      /opt/cibuild/.gimme/versions/go1.20.5.linux.amd64/src/runtime/map.go:695 +0x0
  github.com/algorand/go-algorand/ledger.(*lruAccounts).prune()
      /opt/cibuild/project/ledger/lruaccts.go:163 +0x113
  github.com/algorand/go-algorand/ledger.(*accountUpdates).close()
      /opt/cibuild/project/ledger/acctupdates.go:323 +0xee
  github.com/algorand/go-algorand/ledger.testAcctUpdatesUpdatesCorrectness.func1.2()
      /opt/cibuild/project/ledger/acctupdates_test.go:801 +0x39
  runtime.deferCallSave()
      /opt/cibuild/.gimme/versions/go1.20.5.linux.amd64/src/runtime/panic.go:796 +0x87
  testing.(*T).FailNow()
      <autogenerated>:1 +0x37
  github.com/stretchr/testify/require.Equalf()
      /opt/cibuild/go/pkg/mod/github.com/stretchr/testify@v1.8.4/require/require.go:280 +0x12d
  github.com/algorand/go-algorand/ledger.testAcctUpdatesUpdatesCorrectness.func1()
      /opt/cibuild/project/ledger/acctupdates_test.go:872 +0x2524

Test Plan

Existing tests

[codecov]

Codecov Report

Merging #5619 (1423938) into master (1bf7a21) will increase coverage by 0.03%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5619      +/-   ##
==========================================
+ Coverage   54.95%   54.98%   +0.03%     
==========================================
  Files         463      463              
  Lines       64525    64525              
==========================================
+ Hits        35457    35480      +23     
+ Misses      26684    26664      -20     
+ Partials     2384     2381       -3     

see 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[algorandskiy]

same data race on nightly

[algonautshant]

Looks good. Just trivial fix suggestion for comments.

[cce]

What was merged that caused this race?

[algorandskiy]

#5527 made it much more observable.