Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ledger: increase locks granularity in lookupWithoutRewards" #5620

Merged
merged 1 commit into from Jul 31, 2023

Conversation

algorandskiy
Copy link
Contributor

Reverts #5527 because it causes TestAcctUpdatesUpdatesCorrectness failures. Need to investigate.

@algonautshant
Copy link
Contributor

Are you certain that the problem is in here and not in TestAcctUpdatesUpdatesCorrectness?

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #5620 (272fc41) into master (fd15f4e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5620      +/-   ##
==========================================
+ Coverage   54.99%   55.01%   +0.02%     
==========================================
  Files         463      463              
  Lines       64522    64515       -7     
==========================================
+ Hits        35486    35496      +10     
+ Misses      26657    26646      -11     
+ Partials     2379     2373       -6     
Files Changed Coverage Δ
ledger/acctupdates.go 70.80% <100.00%> (-0.23%) ⬇️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy
Copy link
Contributor Author

algorandskiy commented Jul 29, 2023

I'd rather revert and research outside of master branch.

Failure example

   acctupdates_test.go:872: 
        	Error Trace:	/opt/cibuild/project/ledger/acctupdates_test.go:872
        	Error:      	Not equal: 
        	            	expected: 0x5f5e100
        	            	actual  : 0x5f5e097
        	Test:       	TestAcctUpdatesUpdatesCorrectness/test_with_lru_cache/DiskDB
        	Messages:   	Account index : 3
        	            	Round number : 27

So it looks like lookup from from a previous round or something, and it could be a test issue.

@algorand algorand deleted a comment from pzbitskiy Jul 29, 2023
@cce cce merged commit 1bf7a21 into master Jul 31, 2023
21 checks passed
@cce cce deleted the revert-5527-pavel/locks-deltas branch July 31, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants