New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: write block generator ledger output to a file #5630
tools: write block generator ledger output to a file #5630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5630 +/- ##
=======================================
Coverage 54.97% 54.97%
=======================================
Files 463 463
Lines 64468 64468
=======================================
+ Hits 35439 35441 +2
+ Misses 26650 26649 -1
+ Partials 2379 2378 -1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There are tests for these warn messages. Moving this back to a draft until I can fix them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a non-blocking question.
... well I forgot that questions do block now, until they are addressed/dismissed. Resolved the discussion as well.
Summary
Pass a logger to the ledger when opening it.
Testing
Tested manually.