Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: write block generator ledger output to a file #5630

Merged
merged 8 commits into from Aug 2, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Aug 2, 2023

Summary

Pass a logger to the ledger when opening it.

Testing

Tested manually.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #5630 (0191f75) into master (ba17c2c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5630   +/-   ##
=======================================
  Coverage   54.97%   54.97%           
=======================================
  Files         463      463           
  Lines       64468    64468           
=======================================
+ Hits        35439    35441    +2     
+ Misses      26650    26649    -1     
+ Partials     2379     2378    -1     
Files Changed Coverage Δ
ledger/lrukv.go 95.55% <100.00%> (ø)
ledger/lruresources.go 94.20% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review August 2, 2023 19:17
@winder winder requested review from tzaffi, shiqizng and cce August 2, 2023 19:17
ledger/lrukv.go Show resolved Hide resolved
tzaffi
tzaffi previously approved these changes Aug 2, 2023
shiqizng
shiqizng previously approved these changes Aug 2, 2023
@winder
Copy link
Contributor Author

winder commented Aug 2, 2023

There are tests for these warn messages. Moving this back to a draft until I can fix them.

@winder winder marked this pull request as draft August 2, 2023 20:10
@winder winder dismissed stale reviews from shiqizng and tzaffi via 0191f75 August 2, 2023 20:15
@winder winder marked this pull request as ready for review August 2, 2023 20:15
@winder winder requested review from shiqizng and tzaffi August 2, 2023 20:15
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a non-blocking question.

... well I forgot that questions do block now, until they are addressed/dismissed. Resolved the discussion as well.

@algorandskiy algorandskiy merged commit 0b7958a into algorand:master Aug 2, 2023
18 checks passed
@winder winder deleted the will/ledger-output-to-file branch August 2, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants